[ 
https://issues.apache.org/jira/browse/FLINK-33666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794460#comment-17794460
 ] 

Jim Hughes commented on FLINK-33666:
------------------------------------

This change seems to prevent 
`org.apache.flink.table.api.internal.TableEnvironmentImpl.loadPlan` from 
working on Compiled Plans which used the previous method.  

The PR changes restore test plans which should never be updated.  

I was able to see this since [~bvarghese]'s separate PR was merged to master 
today and it failed CI here:


https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=55321&view=logs&j=0c940707-2659-5648-cbe6-a1ad63045f0a&t=075c2716-8010-5565-fe08-3c4bb45824a4

> MergeTableLikeUtil uses different constraint name than Schema
> -------------------------------------------------------------
>
>                 Key: FLINK-33666
>                 URL: https://issues.apache.org/jira/browse/FLINK-33666
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / Planner
>    Affects Versions: 1.18.0
>            Reporter: Timo Walther
>            Assignee: Jeyhun Karimov
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.19.0
>
>
> {{MergeTableLikeUtil}} uses a different algorithm to name constraints than 
> {{Schema}}. 
> {{Schema}} includes the column names.
> {{MergeTableLikeUtil}} uses a hashCode which means it might depend on JVM 
> specifics.
> For consistency we should use the same algorithm. I propose to use 
> {{Schema}}'s logic.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to