MartijnVisser commented on code in PR #29:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/29#discussion_r1420091784
##########
.github/workflows/ci.yml:
##########
@@ -59,7 +64,7 @@ jobs:
jdk: [8, 11]
timeout-minutes: ${{ inputs.timeout_global }}
env:
- MVN_COMMON_OPTIONS: -U -B --no-transfer-progress -Dflink.version=${{
inputs.flink_version }}
+ MVN_COMMON_OPTIONS: -U -B --no-transfer-progress -Dflink.version=${{
inputs.flink_version }} -P ${{ inputs.optional_maven_profiles }}
Review Comment:
Could we modify this in such a way that we only add this if a extra Maven
profile is set? Right now, we have `non_existing_profile` as a default for all
CI runs, which would create noise since the profile wouldn't exist.
If we would first check if the value is set and only then append it to the
Maven instructions (like is done for the convergence check), I think it would
be cleaner?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
