pvary commented on code in PR #30:
URL: 
https://github.com/apache/flink-connector-shared-utils/pull/30#discussion_r1422406134


##########
.github/workflows/python_ci.yml:
##########
@@ -23,6 +23,11 @@ on:
         description: "Flink version to test against."
         required: true
         type: string
+      jdk_version:
+        description: "Jdk version to test against."
+        required: false
+        default: 8, 11

Review Comment:
   Does this add value to default to 2 different versions?
   The python test infra creation takes serious time, and I am not sure that 
running it twice worth the additional resources committed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to