snuyanzin commented on code in PR #68:
URL:
https://github.com/apache/flink-connector-kafka/pull/68#discussion_r1423178960
##########
pom.xml:
##########
@@ -78,6 +78,13 @@ under the License.
<log4j.version>2.17.1</log4j.version>
<flink.parent.artifactId>flink-connector-kafka-parent</flink.parent.artifactId>
+
+ <!-- This property should contain the add-opens/add-exports commands
required for the tests
+ in the given connector's module to pass.
+ It MUST be a space-separated list not containing any newlines,
+ of entries in the form
'[-]{2}add-[opens|exports]=<module>/<package>=ALL-UNNAMED'.-->
+ <flink.connector.module.config/>
+ <flink.surefire.baseArgLine>-XX:+UseG1GC -Xms256m
-XX:+IgnoreUnrecognizedVMOptions
${flink.connector.module.config}</flink.surefire.baseArgLine>
Review Comment:
IIRC flags are configured in `flink-conf.yaml` at `env.java.opts.all` and
all flags used here are already present there.
That means that currently there is nothing to do.
In theory in future there might appear such necessity e.g. because of some
specific dependencies however I think it should be handled only once it is
required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
