Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2789#discussion_r87738353
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09Fetcher.java
---
@@ -143,133 +123,26 @@ public Kafka09Fetcher(
@Override
public void runFetchLoop() throws Exception {
--- End diff --
We will be throwing all exceptions, even if it's a
`Handover.ClosedException`, correct?
I wonder if it makes sense to suppress `Handover.ClosedException`s to not
reach the main task thread, and only restore the interruption state that
follows `cancel()`? So basically, we catch `InterruptedException` on the whole
`runFetchLoop()` scope.
This was what the exception passing behaviour was like before. Before, when
`cancel()` was called on the fetcher, we won't be throwing any other
exceptions, only restoring the interruption state to the main task thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
