[
https://issues.apache.org/jira/browse/FLINK-33780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795648#comment-17795648
]
Yubin Li commented on FLINK-33780:
----------------------------------
[~hackergin] [~Leonard] Thanks for your review :D
It maybe more appropriate to initialize the default catalog when calling
`Builder.defaultCatalog` rather than when building `CatalogManager`, but
introducing a new method in `CatalogManger.Builder` requires changing all
related calls.
If we adopt the solution, there is only one minor comment that
`CatalogDescriptor` has already included `catalogName`, so it may be more
appropriate to use `defaultCatalog(CatalogDescriptor catalogDescriptor)`. WDYT?
> Support to store default catalog in CatalogStore
> ------------------------------------------------
>
> Key: FLINK-33780
> URL: https://issues.apache.org/jira/browse/FLINK-33780
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / API
> Affects Versions: 1.19.0
> Reporter: Yubin Li
> Priority: Major
> Attachments: image-2023-12-11-13-47-29-623.png,
> image-2023-12-11-14-14-10-002.png, image-2023-12-12-11-09-53-075.png,
> image-2023-12-12-13-42-04-762.png
>
>
> Flink initially creates a default catalog which is included in the
> `Map<String, Catalog> catalogs`, but is not stored in the CatalogStore.
> After conducting thorough investigation, I've determined that the necessary
> modification can be made within the `CatalogManager`.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
