pvary commented on PR #23876: URL: https://github.com/apache/flink/pull/23876#issuecomment-1851714963
> Thanks @pvary for the effort. > > I still have a question whether it is necessary for `CommitterInitContext` to inherit `InitContext`. `CommitterInitContext` seems to be independent and only used for creating `Committer`. Can we make it not inherit any interface and still meet the requirements? [..] > The compatibility issue for `WriteInitContext` comes from this abstraction. Is it possible for us to abandon the abstraction of `InitContext` at the current stage and make further modifications in version 2.0? @Jiabao-Sun: If you take a look at [InitContextBase](https://github.com/apache/flink/pull/23876/commits/a51eff4e2de3f80de61fb45fee81f0de68fd0af3#diff-450ec3a61cf8587c258e2ab3d27bb37945126b4d9e6f23560ff5011cb50b0aaf), you can see that quite a bit of code is deduplicated by the inheritance. Also I am not aware of any compatibility issue caused by splitting the original Sink.InitContext interface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
