1996fanrui commented on code in PR #729:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/729#discussion_r1423772255
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkResourceContext.java:
##########
@@ -65,7 +66,9 @@ public KubernetesJobAutoScalerContext
getJobAutoScalerContext() {
}
private KubernetesJobAutoScalerContext createJobAutoScalerContext() {
- Configuration conf = new Configuration(getObserveConfig());
+ Configuration conf =
+ new KeyMigratingConfiguration(
+ AutoScalerOptions.LEGACY_CONF_PREFIX,
getObserveConfig());
Review Comment:
How about traversing the `getObserveConfig()` and put all keys and values to
a new Configuration? We can removing the prefix directly during traversing.
If so, we don't need to introduce the `KeyMigratingConfiguration` class.
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java:
##########
@@ -46,107 +45,93 @@ private static ConfigOptions.OptionBuilder
autoScalerConfig(String key) {
autoScalerConfig("enabled")
.booleanType()
.defaultValue(false)
- .withFallbackKeys(oldOperatorConfigKey("enabled"))
Review Comment:
Do we need to remove it? I'm not sure should we keep it to let old users
know it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
