[
https://issues.apache.org/jira/browse/FLINK-5058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15663496#comment-15663496
]
ASF GitHub Bot commented on FLINK-5058:
---------------------------------------
GitHub user 397090770 opened a pull request:
https://github.com/apache/flink/pull/2799
[FLINK-5058]taskManagerMemory attribute set wrong value
In FlinkShell.scala, someone mistakenly set `slots` value to
`taskManagerMemory` attribute as follow:
```
// set configuration from user input
yarnConfig.jobManagerMemory.foreach((jmMem) => args ++= Seq("-yjm",
jmMem.toString))
yarnConfig.slots.foreach((tmMem) => args ++= Seq("-ytm", tmMem.toString))
yarnConfig.name.foreach((name) => args ++= Seq("-ynm", name.toString))
yarnConfig.queue.foreach((queue) => args ++= Seq("-yqu", queue.toString))
yarnConfig.slots.foreach((slots) => args ++= Seq("-ys", slots.toString))
```
Note on the third line: `yarnConfig.slots.foreach((tmMem) => args ++=
Seq("-ytm", tmMem.toString))` , we set `slots` value to `taskManagerMemory`
attribute, But in fact, we want to set `taskManagerMemory` attribute, the right
code is as follow:
```
// set configuration from user input
yarnConfig.jobManagerMemory.foreach((jmMem) => args ++= Seq("-yjm",
jmMem.toString))
yarnConfig.taskManagerMemory.foreach((tmMem) => args ++= Seq("-ytm",
tmMem.toString))
yarnConfig.name.foreach((name) => args ++= Seq("-ynm", name.toString))
yarnConfig.queue.foreach((queue) => args ++= Seq("-yqu", queue.toString))
yarnConfig.slots.foreach((slots) => args ++= Seq("-ys", slots.toString))
```
please review tihs pull, thanks.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/397090770/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2799.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2799
----
commit f71f1d3f04f61500834c4d0d99d9b09df812781b
Author: iteblog <[email protected]>
Date: 2016-11-14T11:04:28Z
taskManagerMemory attribute set wrong value
taskManagerMemory attribute set wrong value
----
> slots attribute set wrong value in FlinkShell
> ---------------------------------------------
>
> Key: FLINK-5058
> URL: https://issues.apache.org/jira/browse/FLINK-5058
> Project: Flink
> Issue Type: Bug
> Components: Scala Shell
> Affects Versions: 1.1.3
> Reporter: yangping wu
> Original Estimate: 8h
> Remaining Estimate: 8h
>
> In FlinkShell.scala, someone mistakenly set {{slots}} value to
> {{taskManagerMemory}} attribute as follow:
> {code}
> // set configuration from user input
> yarnConfig.jobManagerMemory.foreach((jmMem) => args ++= Seq("-yjm",
> jmMem.toString))
> yarnConfig.slots.foreach((tmMem) => args ++= Seq("-ytm", tmMem.toString))
> yarnConfig.name.foreach((name) => args ++= Seq("-ynm", name.toString))
> yarnConfig.queue.foreach((queue) => args ++= Seq("-yqu", queue.toString))
> yarnConfig.slots.foreach((slots) => args ++= Seq("-ys", slots.toString))
> {code}
> Note on the third line: {{yarnConfig.slots.foreach((tmMem) => args ++=
> Seq("-ytm", tmMem.toString))}} , we set {{slots}} value to
> {{taskManagerMemory}} attribute, But in fact, we want to set
> {{taskManagerMemory}} attribute, the right code is as follow:
> {code}
> // set configuration from user input
> yarnConfig.jobManagerMemory.foreach((jmMem) => args ++= Seq("-yjm",
> jmMem.toString))
> yarnConfig.taskManagerMemory.foreach((tmMem) => args ++= Seq("-ytm",
> tmMem.toString))
> yarnConfig.name.foreach((name) => args ++= Seq("-ynm", name.toString))
> yarnConfig.queue.foreach((queue) => args ++= Seq("-yqu", queue.toString))
> yarnConfig.slots.foreach((slots) => args ++= Seq("-ys", slots.toString))
> {code}
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
