schulzp commented on PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#issuecomment-1853540370
@reswqa, there are two things that need to be fixed: 1. use `MetricsGroupTestUtils#mockWriterMetricGroup()` instead of `InternalSinkWriterMetricGroup.mock()`, however, the underlying change was introduced [only recently](https://github.com/apache/flink/commit/92951a05127f1e0e2ab0ea04ae022659fc5276ab) code relying on it would not be compatible with 1.17.1 or 1.18.0 2. fix usage of non-public API which is enforced by the `ConnectorRules`, but this would go beyond the scope of this PR, since the main branch triggers those violations (only Java 11 and 17) already, see below ``` [ERROR] Failures: [ERROR] Architecture Violation [Priority: MEDIUM] - Rule 'Connector production code must depend only on public API when outside of connector packages' was violated (11 times): Constructor <org.apache.flink.connector.elasticsearch.sink.ElasticsearchSink.<init>(java.util.List, org.apache.flink.connector.elasticsearch.sink.ElasticsearchEmitter, org.apache.flink.connector.base.DeliveryGuarantee, org.apache.flink.connector.elasticsearch.sink.BulkProcessorBuilderFactory, org.apache.flink.connector.elasticsearch.sink.BulkProcessorConfig, org.apache.flink.connector.elasticsearch.sink.NetworkClientConfig)> calls method <org.apache.flink.util.Preconditions.checkArgument(boolean, java.lang.Object)> in (ElasticsearchSink.java:73) Constructor <org.apache.flink.connector.elasticsearch.sink.ElasticsearchSink.<init>(java.util.List, org.apache.flink.connector.elasticsearch.sink.ElasticsearchEmitter, org.apache.flink.connector.base.DeliveryGuarantee, org.apache.flink.connector.elasticsearch.sink.BulkProcessorBuilderFactory, org.apache.flink.connector.elasticsearch.sink.BulkProcessorConfig, org.apache.flink.connector.elasticsearch.sink.NetworkClientConfig)> calls method <org.apache.flink.util.Preconditions.checkNotNull(java.lang.Object)> in (ElasticsearchSink.java:71) Constructor <org.apache.flink.connector.elasticsearch.sink.ElasticsearchSink.<init>(java.util.List, org.apache.flink.connector.elasticsearch.sink.ElasticsearchEmitter, org.apache.flink.connector.base.DeliveryGuarantee, org.apache.flink.connector.elasticsearch.sink.BulkProcessorBuilderFactory, org.apache.flink.connector.elasticsearch.sink.BulkProcessorConfig, org.apache.flink.connector.elasticsearch.sink.NetworkClientConfig)> calls method <org.apache.flink.util.Preconditions.checkNotNull(java.lang.Object)> in (ElasticsearchSink.java:72) Constructor <org.apache.flink.connector.elasticsearch.sink.ElasticsearchSink.<init>(java.util.List, org.apache.flink.connector.elasticsearch.sink.ElasticsearchEmitter, org.apache.flink.connector.base.DeliveryGuarantee, org.apache.flink.connector.elasticsearch.sink.BulkProcessorBuilderFactory, org.apache.flink.connector.elasticsearch.sink.BulkProcessorConfig, org.apache.flink.connector.elasticsearch.sink.NetworkClientConfig)> calls method <org.apache.flink.util.Preconditions.checkNotNull(java.lang.Object)> in (ElasticsearchSink.java:74) Constructor <org.apache.flink.connector.elasticsearch.sink.ElasticsearchSink.<init>(java.util.List, org.apache.flink.connector.elasticsearch.sink.ElasticsearchEmitter, org.apache.flink.connector.base.DeliveryGuarantee, org.apache.flink.connector.elasticsearch.sink.BulkProcessorBuilderFactory, org.apache.flink.connector.elasticsearch.sink.BulkProcessorConfig, org.apache.flink.connector.elasticsearch.sink.NetworkClientConfig)> calls method <org.apache.flink.util.Preconditions.checkNotNull(java.lang.Object)> in (ElasticsearchSink.java:75) Constructor <org.apache.flink.connector.elasticsearch.sink.ElasticsearchSink.<init>(java.util.List, org.apache.flink.connector.elasticsearch.sink.ElasticsearchEmitter, org.apache.flink.connector.base.DeliveryGuarantee, org.apache.flink.connector.elasticsearch.sink.BulkProcessorBuilderFactory, org.apache.flink.connector.elasticsearch.sink.BulkProcessorConfig, org.apache.flink.connector.elasticsearch.sink.NetworkClientConfig)> calls method <org.apache.flink.util.Preconditions.checkNotNull(java.lang.Object)> in (ElasticsearchSink.java:76) Constructor <org.apache.flink.connector.elasticsearch.sink.ElasticsearchSink.<init>(java.util.List, org.apache.flink.connector.elasticsearch.sink.ElasticsearchEmitter, org.apache.flink.connector.base.DeliveryGuarantee, org.apache.flink.connector.elasticsearch.sink.BulkProcessorBuilderFactory, org.apache.flink.connector.elasticsearch.sink.BulkProcessorConfig, org.apache.flink.connector.elasticsearch.sink.NetworkClientConfig)> calls method <org.apache.flink.util.Preconditions.checkNotNull(java.lang.Object)> in (ElasticsearchSink.java:77) Constructor <org.apache.flink.connector.elasticsearch.sink.ElasticsearchWriter.<init>(java.util.List, org.apache.flink.connector.elasticsearch.sink.ElasticsearchEmitter, boolean, org.apache.flink.connector.elasticsearch.sink.BulkProcessorConfig, org.apache.flink.connector.elasticsearch.sink.BulkProcessorBuilderFactory, org.apache.flink.connector.elasticsearch.sink.NetworkClientConfig, org.apache.flink.metrics.groups.SinkWriterMetricGroup, org.apache.flink.api.common.operators.MailboxExecutor)> calls method <org.apache.flink.util.Preconditions.checkNotNull(java.lang.Object)> in (ElasticsearchWriter.java:107) Constructor <org.apache.flink.connector.elasticsearch.sink.ElasticsearchWriter.<init>(java.util.List, org.apache.flink.connector.elasticsearch.sink.ElasticsearchEmitter, boolean, org.apache.flink.connector.elasticsearch.sink.BulkProcessorConfig, org.apache.flink.connector.elasticsearch.sink.BulkProcessorBuilderFactory, org.apache.flink.connector.elasticsearch.sink.NetworkClientConfig, org.apache.flink.metrics.groups.SinkWriterMetricGroup, org.apache.flink.api.common.operators.MailboxExecutor)> calls method <org.apache.flink.util.Preconditions.checkNotNull(java.lang.Object)> in (ElasticsearchWriter.java:97) Constructor <org.apache.flink.connector.elasticsearch.sink.ElasticsearchWriter.<init>(java.util.List, org.apache.flink.connector.elasticsearch.sink.ElasticsearchEmitter, boolean, org.apache.flink.connector.elasticsearch.sink.BulkProcessorConfig, org.apache.flink.connector.elasticsearch.sink.BulkProcessorBuilderFactory, org.apache.flink.connector.elasticsearch.sink.NetworkClientConfig, org.apache.flink.metrics.groups.SinkWriterMetricGroup, org.apache.flink.api.common.operators.MailboxExecutor)> calls method <org.apache.flink.util.Preconditions.checkNotNull(java.lang.Object)> in (ElasticsearchWriter.java:99) Method <org.apache.flink.connector.elasticsearch.sink.ElasticsearchWriter.extractFailures(org.elasticsearch.action.bulk.BulkRequest, org.elasticsearch.action.bulk.BulkResponse)> calls method <org.apache.flink.util.ExceptionUtils.firstOrSuppressed(java.lang.Throwable, java.lang.Throwable)> in (ElasticsearchWriter.java:264) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
