mxm commented on code in PR #730:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/730#discussion_r1425156114
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java:
##########
@@ -375,9 +376,24 @@ private int getParallelism() {
* effectiveConfig.get(TaskManagerOptions.NUM_TASK_SLOTS);
}
+ Optional<Integer> maxOverrideParallelism =
getMaxParallelismFromOverrideConfig();
+ if (maxOverrideParallelism.isPresent() && maxOverrideParallelism.get()
> 0) {
+ return maxOverrideParallelism.get();
+ }
+
return spec.getJob().getParallelism();
}
+ private Optional<Integer> getMaxParallelismFromOverrideConfig() {
Review Comment:
If this method is used to determine the number of required task slots to run
the job, that won't work if slot sharing is disabled or if multiple slot
sharing groups are used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
