mxm commented on PR #729: URL: https://github.com/apache/flink-kubernetes-operator/pull/729#issuecomment-1855734056
While testing, I noticed that the abstraction in the PR doesn't fully hold because there is code in the reconciler which access autoscaler options and uses the observe config instead of the migrated config, e.g. [here](https://github.com/apache/flink-kubernetes-operator/blob/2136c7a3189753c45e167920bd509a687218a57f/flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java#L190). I could fix this but I fear that the abstraction might become leaky again in the future. I'm closing this PR because I want to avoid adding too much complexity to the config key handling. The current approach to use fallback instead of deprecated keys is fine. Fallback keys are logged at INFO, so we can simply set the logging for `Configuration` to WARN. See: https://github.com/apache/flink-kubernetes-operator/pull/734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
