xintongsong commented on code in PR #23870:
URL: https://github.com/apache/flink/pull/23870#discussion_r1427504078
##########
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java:
##########
@@ -173,6 +173,18 @@ public class TaskManagerOptions {
+ RPC_PORT.key()
+ "') will be used.");
+ /** The default port that <code>CollectSinkFunction$ServerThread</code> is
using. */
+ @Documentation.Section({
+ Documentation.Sections.COMMON_HOST_PORT,
+ Documentation.Sections.ALL_TASK_MANAGER
+ })
+ public static final ConfigOption<Integer> COLLECT_PORT =
+ key("taskmanager.collect.port")
Review Comment:
I'd suggest the key `taskmanager.collect-sink.port`.
##########
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java:
##########
@@ -173,6 +173,18 @@ public class TaskManagerOptions {
+ RPC_PORT.key()
+ "') will be used.");
+ /** The default port that <code>CollectSinkFunction$ServerThread</code> is
using. */
+ @Documentation.Section({
+ Documentation.Sections.COMMON_HOST_PORT,
+ Documentation.Sections.ALL_TASK_MANAGER
+ })
+ public static final ConfigOption<Integer> COLLECT_PORT =
+ key("taskmanager.collect.port")
+ .intType()
+ .defaultValue(0)
+ .withDescription(
+ "The local port that the
CollectSinkFunction$ServerThread binds to. The default is 0, which corresponds
to a random port assignment.");
Review Comment:
I think the current description is kind of developer oriented, rather than
user oriented. `CollectSinkFunction` is an `@Internal` class. Ideally, this
should only be used for Flink's client, and users should not be aware of it.
From a user's perspective, I think they only need to know that this port is for
the client to retrieve query results from the TaskManager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
