reta commented on PR #38: URL: https://github.com/apache/flink-connector-opensearch/pull/38#issuecomment-1858813200
> Since currently (main branch) connector is building with jdk8, 11 then IIUC it doesn't solve the issue when connector both for v1 and v2 is building with jdk11. Or did I miss anything? Correct, hence the profiles that we touched upon the other day, jdk-8 - 1.x, jdk-11 - 2.x > Here in the PR I also extracted common classes into base module and in v1, v2 related modules are only opensearch api dependent classes I have objections to that (it is a right way to me), I am just suggesting more simpler alternative that we might consider -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
