xuyangzhong commented on code in PR #23827:
URL: https://github.com/apache/flink/pull/23827#discussion_r1429367900


##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/aggregate/JsonObjectAggFunction.java:
##########
@@ -128,6 +137,15 @@ public void merge(Accumulator acc, Iterable<Accumulator> 
others) throws Exceptio
                 assertKeyNotPresent(acc, key);
                 acc.map.put(key, other.map.get(key));
             }
+            for (final StringData key : other.retractMap.keys()) {

Review Comment:
   IIUC, for retract streams, if -U comes before +U, +U might also be 
eliminated?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to