liyubin117 commented on code in PR #23678:
URL: https://github.com/apache/flink/pull/23678#discussion_r1429393701
##########
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/DataGenTableSourceFactory.java:
##########
@@ -141,15 +143,15 @@ private DataGeneratorContainer createContainer(
}
private void validateFieldOptions(String name, DataType type,
ReadableConfig options) {
- ConfigOption<Boolean> lenOption =
+ ConfigOption<Boolean> varLenOption =
key(DataGenConnectorOptionsUtil.FIELDS
+ "."
+ name
+ "."
+ DataGenConnectorOptionsUtil.VAR_LEN)
.booleanType()
.defaultValue(false);
- options.getOptional(lenOption)
+ options.getOptional(varLenOption)
Review Comment:
sorry to misunderstand. I invoke this to filter the table that contains `
'fields.#.var-len' = 'true' `, then we could use `ifPresent` check if it is
sufficient to use such option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
