JunRuiLee commented on code in PR #23447:
URL: https://github.com/apache/flink/pull/23447#discussion_r1429785675
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java:
##########
@@ -126,9 +140,14 @@ public synchronized void
updateCurrentExecutionAttempts(Collection<JobDetails> j
taskMetricStore.getSubtaskMetricStore(
subtaskIndex))
.ifPresent(
- subtaskMetricStore ->
-
subtaskMetricStore.retainAttempts(
-
attempts.getCurrentAttempts()));
+ subtaskMetricStore -> {
+
subtaskMetricStore.retainAttempts(
Review Comment:
Clean up simultaneously for both cases first here sounds good to me, Please
feel free and go ahead~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
