mxm commented on code in PR #728:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1431648293
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java:
##########
@@ -147,7 +149,13 @@ public CollectedMetricHistory updateMetrics(
if (now.isBefore(windowFullTime)) {
LOG.info("Metric window not full until {}",
readable(windowFullTime));
} else {
- collectedMetrics.setFullyCollected(true);
+ if (isExcluded) {
+ LOG.info(
+ "Autoscaling on halt based on exclusion rule {}",
+ conf.get(AutoScalerOptions.EXCLUDED_PERIODS));
+ } else {
+ collectedMetrics.setFullyCollected(true);
+ }
Review Comment:
Although the current logic works fine for blocking the scaling during the
configured phases, I agree that the logic would be better suited for
ScalingExecutor. There are other features, e.g. recommended parallelism, which
will stop working if the metric collection phase hasn't completed. We only want
to block executing the scaling. All other logic should run normally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
