[
https://issues.apache.org/jira/browse/FLINK-5066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665047#comment-15665047
]
ASF GitHub Bot commented on FLINK-5066:
---------------------------------------
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/2806
[FLINK-5066] Prevent LocalInputChannel#getNextBuffer from de-serialising
all events when looking for EndOfPartitionEvent only
LocalInputChannel#getNextBuffer de-serialises all incoming events on the
lookout for an EndOfPartitionEvent.
Instead, add EventSerializer.isEvent so that LocalInputChannel can peak
into event buffers without de-serialising the whole event, we could save some
resources. This is a generic isEvent implementation for any event that
fromSerializedEvent currently supports. Alternatively, a specialised method
could be implemented looking for EndOfPartitionEvent only, if desired.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink FLINK-5066
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2806.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2806
----
commit bf394e8f9ab18991f29942f3017ecc04643ce224
Author: Nico Kruber <[email protected]>
Date: 2016-11-14T19:02:54Z
[FLINK-5066] add EventSerializer.isEvent so that LocalInputChannel can peak
into event buffers
----
> prevent LocalInputChannel#getNextBuffer from de-serialising all events when
> looking for EndOfPartitionEvent only
> ----------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-5066
> URL: https://issues.apache.org/jira/browse/FLINK-5066
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> LocalInputChannel#getNextBuffer de-serialises all incoming events on the
> lookout for an EndOfPartitionEvent.
> Instead, if EventSerializer offered a function to check for an event type
> only without de-serialising the whole event, we could save some resources.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
