twalthr commented on code in PR #23948:
URL: https://github.com/apache/flink/pull/23948#discussion_r1432489408
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/PlannerQueryOperation.java:
##########
@@ -72,6 +77,15 @@ public String asSummaryString() {
"PlannerNode", Collections.emptyMap(), getChildren(),
Operation::asSummaryString);
}
+ @Override
+ public String asSerializableString() {
+ try {
+ return toSqlString.get();
+ } catch (Exception e) {
+ throw new TableException("Could not convert Calcite tree to a SQL
string", e);
Review Comment:
I would rephrase to `Given plan is not serializable into SQL` or so. Not
mention Calicte.
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/TableTestBase.scala:
##########
@@ -1646,6 +1650,28 @@ object TableTestUtil {
planner.translateToRel(modifyOperation)
}
+ def toQuotedSqlString(relNode: RelNode, tEnv: TableEnvironment): String = {
Review Comment:
Who is calling this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
