[
https://issues.apache.org/jira/browse/FLINK-33641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799011#comment-17799011
]
Jiabao Sun commented on FLINK-33641:
------------------------------------
Hi [~mapohl], please take a look at this PR
[https://github.com/apache/flink/pull/23917]
In the previous fix, I think we shouldn't reuse the tempFolder to create a new
temporary folder.
Although we clean up the newly created directory during the "after" method, it
is still possible for the checkpoint thread to continue writing, resulting in
the failure of JUnit5 TemporaryFolder cleanup.
https://github.com/apache/flink/pull/23917#discussion_r1428188735
I think this problem was fixed by 23917, so could you help include the commit
ac88acfbb1b4ebf7336e9a20e0b6d0b0fe32be51 and try it again?
> JUnit5 fails to delete a directory on AZP for various table-planner tests
> -------------------------------------------------------------------------
>
> Key: FLINK-33641
> URL: https://issues.apache.org/jira/browse/FLINK-33641
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
> Affects Versions: 1.19.0
> Reporter: Sergey Nuyanzin
> Assignee: Jiabao Sun
> Priority: Critical
> Labels: pull-request-available, test-stability
> Fix For: 1.19.0
>
>
> this build
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=54856&view=logs&j=a9db68b9-a7e0-54b6-0f98-010e0aff39e2&t=cdd32e0b-6047-565b-c58f-14054472f1be&l=11289
> fails with
> {noformat}
> Nov 24 02:21:53 Suppressed: java.nio.file.DirectoryNotEmptyException:
> /tmp/junit1727687356898183357/junit4798298549994985259/1ac07a5866d81240870d5a2982531508
> Nov 24 02:21:53 at
> sun.nio.fs.UnixFileSystemProvider.implDelete(UnixFileSystemProvider.java:242)
> Nov 24 02:21:53 at
> sun.nio.fs.AbstractFileSystemProvider.delete(AbstractFileSystemProvider.java:103)
> Nov 24 02:21:53 at java.nio.file.Files.delete(Files.java:1126)
> Nov 24 02:21:53 at
> org.junit.jupiter.engine.extension.TempDirectory$CloseablePath$1.deleteAndContinue(TempDirectory.java:293)
> Nov 24 02:21:53 at
> org.junit.jupiter.engine.extension.TempDirectory$CloseablePath$1.postVisitDirectory(TempDirectory.java:288)
> Nov 24 02:21:53 at
> org.junit.jupiter.engine.extension.TempDirectory$CloseablePath$1.postVisitDirectory(TempDirectory.java:264)
> Nov 24 02:21:53 at
> java.nio.file.Files.walkFileTree(Files.java:2688)
> Nov 24 02:21:53 at
> java.nio.file.Files.walkFileTree(Files.java:2742)
> Nov 24 02:21:53 at
> org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.deleteAllFilesAndDirectories(TempDirectory.java:264)
> Nov 24 02:21:53 at
> org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.close(TempDirectory.java:249)
> Nov 24 02:21:53 ... 92 more
> {noformat}
> not sure however this might be related to recent JUnit4 => JUnit5 upgrade
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
