reswqa commented on code in PR #23954:
URL: https://github.com/apache/flink/pull/23954#discussion_r1433628981
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/DiskIOScheduler.java:
##########
@@ -206,9 +206,9 @@ private int readBuffersFromFile() {
Queue<MemorySegment> buffers;
try {
buffers = allocateBuffers();
- } catch (Exception exception) {
- failScheduledReaders(scheduledReaders, exception);
- LOG.error("Failed to request buffers for data reading.",
exception);
+ } catch (Exception e) {
Review Comment:
Alright, `BatchShuffleReadBufferPool#requestBuffers()` abuses the
declaration of ambiguous exception. It should be limited to it's own home, but
this indeed out of the scope of this PR. So let's keep as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
