gyfora commented on code in PR #728:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1434220037
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java:
##########
@@ -264,4 +262,21 @@ private static Map<String, String>
getVertexParallelismOverrides(
});
return overrides;
}
+
+ private boolean blockScalingExecution(
Review Comment:
We should rename this to `triggerScalingEvent` or
`checkIfBlockedAndTriggerScalingEvent` or add javadocs or something that
suggests that the scaling event is triggered inside
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
