zoudan opened a new pull request, #23984:
URL: https://github.com/apache/flink/pull/23984
## What is the purpose of the change
This pull request ensure that we generate the same code for the same logic,
it is a precondition for sharing generated classes between different jobs.
## Brief change log
- add a name counter in each `CodeGeneratorContext` and use it when we
generate names for variables.
## Verifying this change
Please make sure both new and modified tests in this PR follows the
conventions defined in our code quality guide:
https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
This change added tests and can be verified as follows:
- Add a new test: CodeGenUtilsTest#testNewName
- Add tests in existing class:
HashCodeGeneratorTest#testHashWithIndependentNameCounter and
ProjectionCodeGeneratorTest#testHashWithIndependentNameCounter
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (docs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
