xuyangzhong opened a new pull request, #23991:
URL: https://github.com/apache/flink/pull/23991
## What is the purpose of the change
In some exec nodes like StreamExecGroupWindowAggregate and some rules like
BatchPhysicalWindowAggregateRule, planner uses "AggregateUtil#timeFieldIndex"
to access the actual time field index, instead of using the time field index in
LogicalWindow#timeAttribute directly. However, it would be more formal to use
the field index instead of the column field.
## Brief change log
- *Deprecate AggregateUtil#timeFieldIndex*
- *update the code using "AggregateUtil.timeFieldIndex(input.getRowType,
call.builder(), window.timeAttribute)" before to use
"window.timeAttribute.getFieldIndex"*
- *Fix the rule that doesn't update the index in window before while
optimizing plan*
## Verifying this change
All existent tests can cover this fix.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
