[ 
https://issues.apache.org/jira/browse/FLINK-33947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800794#comment-17800794
 ] 

RocMarshal commented on FLINK-33947:
------------------------------------

hi, [~fanrui] thanks for your attention.

I want to set the prefix attribute as Nonnull (@Nonnull)
There are two benefits to this:

- Ensure that potential _*NPE*_ risks can be addressed

- Maintain minimal changes (in my limited read, since the initial design 
allowed prefixes to default to empty strings, I tend to maintain this default 
strategy to ensure some backward compatibility space is left. Of course, if it 
is necessary not to allow prefixes to be empty strings, I am happy to make 
corresponding changes)

Please let me know what's your opinion~

> Fix bugs in DelegatingConfiguration missed the prefix mapping 
> --------------------------------------------------------------
>
>                 Key: FLINK-33947
>                 URL: https://issues.apache.org/jira/browse/FLINK-33947
>             Project: Flink
>          Issue Type: Bug
>          Components: API / Core
>            Reporter: RocMarshal
>            Assignee: RocMarshal
>            Priority: Major
>             Fix For: 1.19.0, 1.17.3, 1.18.2
>
>
> It was resulted from 
> [https://github.com/apache/flink/pull/23994#issuecomment-1869905090] 
> -  Check and confirm other potential bug points
> -  Fix the bugs about prefix key mapping when operating.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to