WencongLiu commented on code in PR #23905:
URL: https://github.com/apache/flink/pull/23905#discussion_r1440107366
##########
flink-core/src/main/java/org/apache/flink/api/connector/source/SourceReaderContext.java:
##########
@@ -39,7 +41,16 @@ public interface SourceReaderContext {
*/
String getLocalHostName();
- /** @return The index of this subtask. */
+ /**
+ * Get the index of this subtask.
+ *
+ * @deprecated This method is deprecated since Flink 1.19. All metadata
about the task should be
+ * provided uniformly by {@link #getTaskInfo()}.
+ * @see <a
+ *
href="https://cwiki.apache.org/confluence/display/FLINK/FLIP-382%3A+Unify+the+Provision+of+Diverse+Metadata+for+Context-like+APIs";>
+ * FLIP-382: Unify the Provision of Diverse Metadata for Context-like
APIs </a>
+ */
+ @Deprecated
int getIndexOfSubtask();
Review Comment:
For these deprecated methods in the modified interfaces, I've changed them
from abstract to default and provided default implementations.
##########
flink-core/src/main/java/org/apache/flink/core/failure/FailureEnricher.java:
##########
@@ -84,14 +88,26 @@ enum FailureType {
* Get the ID of the job.
*
* @return the ID of the job
+ * @deprecated This method is deprecated since Flink 1.19. All
metadata about the job should
+ * be provided uniformly by {@link #getJobInfo()}.
+ * @see <a
+ *
href="https://cwiki.apache.org/confluence/display/FLINK/FLIP-382%3A+Unify+the+Provision+of+Diverse+Metadata+for+Context-like+APIs";>
+ * FLIP-382: Unify the Provision of Diverse Metadata for
Context-like APIs </a>
*/
+ @Deprecated
Review Comment:
For these deprecated methods in the modified interfaces, I've changed them
from abstract to default and provided default implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
