Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2797#discussion_r88021880
--- Diff:
flink-streaming-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
---
@@ -426,17 +424,63 @@ public void close() throws Exception {
}
}
+ // TODO: 11/10/16 this should be the close() after
+ // introducing the dispose() method in the RichFunction.
+ // ATTENTION: it is not thoroughly tested yet.
+ public void closeAfterDisposeIsIntroduced() throws Exception {
--- End diff --
You remove this method in a later commit, why add it in the first place?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
