pnowojski commented on code in PR #23908:
URL: https://github.com/apache/flink/pull/23908#discussion_r1441711709
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java:
##########
@@ -730,57 +739,87 @@ void restoreInternal() throws Exception {
getEnvironment().getMetricGroup().getIOMetricGroup().markTaskInitializationStarted();
LOG.debug("Initializing {}.", getName());
- operatorChain =
-
getEnvironment().getTaskStateManager().isTaskDeployedAsFinished()
- ? new FinishedOperatorChain<>(this, recordWriter)
- : new RegularOperatorChain<>(this, recordWriter);
- mainOperator = operatorChain.getMainOperator();
+ SubTaskInitializationMetricsBuilder initializationMetrics =
+ new SubTaskInitializationMetricsBuilder(
+ SystemClock.getInstance().absoluteTimeMillis());
+ try {
+ operatorChain =
+
getEnvironment().getTaskStateManager().isTaskDeployedAsFinished()
+ ? new FinishedOperatorChain<>(this, recordWriter)
+ : new RegularOperatorChain<>(this, recordWriter);
+ mainOperator = operatorChain.getMainOperator();
- getEnvironment()
- .getTaskStateManager()
- .getRestoreCheckpointId()
- .ifPresent(restoreId -> latestReportCheckpointId = restoreId);
+ getEnvironment()
Review Comment:
try/catch was added here
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/SubTaskInitializationMetricsBuilder.java:
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.checkpoint;
+
+import org.apache.flink.annotation.VisibleForTesting;
+
+import javax.annotation.concurrent.NotThreadSafe;
+
+import java.util.HashMap;
+import java.util.Map;
+
+/**
+ * A builder for {@link SubTaskInitializationMetrics}.
+ *
+ * <p>This class is not thread safe, but parts of it can actually be used from
different threads.
Review Comment:
Is it needed? Just construct the object and optionally call setters.
note,
> <p>This class is not thread safe, but parts of it can actually be used
from different threads.
was a copy/paste artifact. I removed that comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
