lajith2006 opened a new pull request, #749:
URL: https://github.com/apache/flink-kubernetes-operator/pull/749
<!--
*Thank you very much for contributing to the Apache Flink Kubernetes
Operator - we are happy that you want to help us improve the project. To help
the community review your contribution in the best possible way, please go
through the checklist below, which will get the contribution into a shape in
which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA
issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are
made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the
pull request", where *FLINK-XXXX* should be replaced by the actual issue
number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following
this pattern: `[hotfix][docs] Fix typo in event time introduction` or
`[hotfix][javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes. You can read more on how we use GitHub Actions for CI
[here](https://nightlies.apache.org/flink/flink-kubernetes-operator-docs-main/docs/development/guide/#cicd).
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
(including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
This PR is for issue https://issues.apache.org/jira/browse/FLINK-33634 to
add Conditions field in the CR status of Flink Deployment and FlinkSessionJob.
## Brief change log
- Created a new class CommonCRStatus to build different Conditions with
type and status. This reusable class can be used to build CR condition of type
Ready or Error conditions based on jobmanager status and job status.
- FlinkDeploymentStatus is updated to add list of Condition
- FlinkDeploymentController is updated to add Conditions to
FlinkDeploymentStatus based on JobManagerDeploymentStatus. Following
JobManagerDeploymentStatus are considerd to
add conditions status to CR.
READY
DEPLOYED_NOT_READY
DEPLOYING
ERROR
- FlinkSessionJobStatus is updated to add list of Condition
- FlinkSessionJobController is updated to add Conditions to
FlinkSessionJobStatus based on JobStatus. Following JobStatus are considered to
add conditions status to CR
RUNNING
CREATED
CANCELED
FAILED
- FlinkDeploymentControllerTest and FlinkSessionJobControllerTest are
modified to test the Status update with conditions.
## Verifying this change
<!--
Please make sure both new and modified tests in this PR follows the
conventions defined in our code quality guide:
https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
-->
This change is already covered by existing tests, such as
FlinkDeploymentControllerTest and FlinkSessionJobControllerTest
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no) no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
(yes / no) yes
- Core observer or reconciler logic that is regularly executed: (yes / no)
yes
## Documentation
- Does this pull request introduce a new feature? (yes / no) yes
- If yes, how is the feature documented? (not applicable / docs / JavaDocs
/ not documented) docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
