XComp commented on code in PR #22984:
URL: https://github.com/apache/flink/pull/22984#discussion_r1442629925
##########
flink-core/src/main/java/org/apache/flink/api/common/restartstrategy/RestartStrategies.java:
##########
@@ -72,9 +72,23 @@ public static RestartStrategyConfiguration fixedDelayRestart(
* @param restartAttempts Number of restart attempts for the
FixedDelayRestartStrategy
* @param delayInterval Delay in-between restart attempts for the
FixedDelayRestartStrategy
* @return FixedDelayRestartStrategy
+ * @deprecated Use {@link #fixedDelayRestart(int, Duration)}
*/
+ @Deprecated
Review Comment:
Another reason would be that not touching `RestartStrategies` means that we
have a (soft) dependencies between FLIP-381 and FLIP-335. With the alternative
methods in `RestartStrategies` in place, we can go ahead with FLIP-335 in a
more straight-forward fashion and don't need to wait with removing the `Time`
classes until FLIP-381 is resolved. :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
