jeyhunkarimov opened a new pull request, #24033:
URL: https://github.com/apache/flink/pull/24033

   
   ## What is the purpose of the change
   
   The current optimizer/planner merges two Projection/Calc nodes if they are 
deterministic. 
   In some scenarios, this check is not enough. Especially, when the top 
Projection/Calc 
   node uses the already computed value from the bottom Project/Calc node, 
merging
   the two of them might lead to redundant computation (recomputing the same 
   expressions several times). In fact, our tests contained many tests that 
   computed the same expression several times.
   
   
   ## Brief change log
   
     - Extend the `mergeable` method and add an additional check
     - Add tests
   
   
   ## Verifying this change
   
   This change added tests to `CalcMergeTestBase`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: ( no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to