davidradl commented on code in PR #79:
URL: 
https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1444024895


##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/ParameterizedPredicate.java:
##########
@@ -52,8 +69,26 @@ public void setPredicate(String predicate) {
     }
 
     public ParameterizedPredicate combine(String operator, 
ParameterizedPredicate that) {
+        int paramIndex = String.format("(%s %s ", this.predicate, 
operator).length();
+        if (!that.indexesOfPredicatePlaceHolders.isEmpty()) {
+            paramIndex = paramIndex + 
that.indexesOfPredicatePlaceHolders.get(0);

Review Comment:
   @snuyanzin thanks I will look to recreate. Assuming you are ok with the 
general approach - I am thinking that the resolution will be to handle multiple 
existing indices. I will investigate.   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to