snuyanzin commented on code in PR #2: URL: https://github.com/apache/flink-connector-jdbc/pull/2#discussion_r1444113533
########## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/sink/committer/JdbcCommitable.java: ########## @@ -0,0 +1,39 @@ +package org.apache.flink.connector.jdbc.sink.committer; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.connector.jdbc.datasource.transactions.xa.XaTransaction; + +import javax.annotation.Nullable; +import javax.transaction.xa.Xid; + +import java.io.Serializable; +import java.util.Optional; + +/** */ Review Comment: I guess need to fill it ########## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/sink/committer/JdbcCommitableSerializer.java: ########## @@ -0,0 +1,37 @@ +package org.apache.flink.connector.jdbc.sink.committer; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.common.typeutils.TypeSerializer; +import org.apache.flink.connector.jdbc.xa.XidSerializer; +import org.apache.flink.core.io.SimpleVersionedSerializer; +import org.apache.flink.core.memory.DataInputDeserializer; +import org.apache.flink.core.memory.DataOutputSerializer; + +import javax.transaction.xa.Xid; + +import java.io.IOException; + +/** */ Review Comment: I guess need to fill it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
