xuyangzhong commented on code in PR #23752:
URL: https://github.com/apache/flink/pull/23752#discussion_r1445536689
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/QueryHintsResolver.java:
##########
@@ -84,6 +85,12 @@ protected RelNode visitBiRel(BiRel biRel) {
Set<RelHint> existentKVHints = new HashSet<>();
List<RelHint> oldHints = ((Hintable) biRel).getHints();
+ List<RelHint> oldQueryHints = FlinkHints.getAllQueryHints(oldHints);
+ // has no hints, return directly.
+ if (oldQueryHints.isEmpty()) {
+ return super.visitChildren(biRel);
+ }
+
Review Comment:
For example, table hints. Return directly here because the current BiRel may
not have query hints, so there is no need to process it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
