XComp commented on code in PR #23970: URL: https://github.com/apache/flink/pull/23970#discussion_r1446358342
########## .github/actions/run_mvn/action.yml: ########## @@ -0,0 +1,42 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +--- +name: "Runs Maven Command" Review Comment: You're right, I used the wrong environment variable in my comment above. The example should be `GITHUB_ENV`. The JDK setting is added to `GITHUB_ENV` in the `set_java_in_container` custom action. It's not "automagically" added to the environment. I did test runs for bash functions and exporting env variables (see [workflow](https://github.com/XComp/github-actions-playground/actions/runs/7463171863/job/20307209534#step:4:5)). Neither the function nor the variable are passed down to subsequent steps if you don't use `GITHUB_ENV` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
