jiangxin369 commented on code in PR #23957:
URL: https://github.com/apache/flink/pull/23957#discussion_r1447205769
##########
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/shuffle/TieredResultPartitionTest.java:
##########
@@ -192,15 +188,34 @@ void testMetricsUpdateForBroadcastOnlyResultPartition()
throws Exception {
try (TieredResultPartition partition =
createTieredStoreResultPartition(2, bufferPool, true)) {
partition.broadcastRecord(ByteBuffer.allocate(bufferSize));
- IOMetrics ioMetrics = taskIOMetricGroup.createSnapshot();
- assertThat(ioMetrics.getResultPartitionBytes()).hasSize(1);
- ResultPartitionBytes partitionBytes =
-
ioMetrics.getResultPartitionBytes().values().iterator().next();
- assertThat(partitionBytes.getSubpartitionBytes())
- .containsExactly(bufferSize, bufferSize);
+ verifySubpartitionBytes(bufferSize, bufferSize);
}
}
+ @Test
+ void testRequestBuffersAfterPoolSizeDecreased() throws IOException {
Review Comment:
Good catch. The test would fail before this PR at first, but I forgot to
keep the behavior after some changes which made it not expected. I've
rollbacked it, please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
