xuyangzhong commented on code in PR #24051:
URL: https://github.com/apache/flink/pull/24051#discussion_r1448449006
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/agg/AggsHandlerCodeGenerator.scala:
##########
@@ -447,6 +473,23 @@ class AggsHandlerCodeGenerator(
val recordInputName = newName("recordInput")
val recordToRowDataCode = genRecordToRowData(aggExternalType,
recordInputName)
+ // for emitUpdateWithRetract, the collector needs to implement
RetractableCollector
+ // and override retract method
+ val (collectorClassName, collectorRetractCode) =
+ if (isIncrementalUpdateNeeded)
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
