JunRuiLee commented on PR #23852: URL: https://github.com/apache/flink/pull/23852#issuecomment-1886692234
Hi @zhuzhurk , Thanks for reviewing. I've updated the PR with the necessary changes. Please take a look~ Here are some clarifications I'd like to make: 1. Concerning the thread safety issues of the GlobalConfiguration.isStandardYaml state during concurrent tests, the current testing framework in Flink ensures tests are run sequentially between different test classes within the same process. This setup means we only need to ensure the consistency of that state upon the completion of each test class. 2. Regarding the updates needed for comments within the code and specific code references to "flink-conf.yaml" (for example, in YarnTestBase), I intend to address these adjustments in a follow-up task. This subsequent task will involve updating the default configuration file in flink-dist to config.yaml, at which time I plan to collectively revise both the comments in the code and the relevant code references. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
