gaborgsomogyi commented on code in PR #23930:
URL: https://github.com/apache/flink/pull/23930#discussion_r1448609124
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java:
##########
@@ -632,35 +634,33 @@ private static <P extends ResponseBody>
CompletableFuture<P> parseResponse(
CompletableFuture<P> responseFuture = new CompletableFuture<>();
final JsonParser jsonParser =
objectMapper.treeAsTokens(rawResponse.json);
try {
- P response = objectMapper.readValue(jsonParser, responseType);
- responseFuture.complete(response);
- } catch (IOException originalException) {
- // the received response did not matched the expected response type
-
- // lets see if it is an ErrorResponse instead
- try {
+ // We make sure it fits to ErrorResponseBody, this condition is
enforced by test
Review Comment:
This test is not yet added, because I want to see if the new approach works
or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
