zentol commented on code in PR #23970:
URL: https://github.com/apache/flink/pull/23970#discussion_r1448648335
##########
pom.xml:
##########
@@ -1104,17 +1103,19 @@ under the License.
</properties>
<build>
- <pluginManagement>
- <plugins>
- <plugin>
-
<groupId>org.apache.maven.plugins</groupId>
-
<artifactId>maven-surefire-plugin</artifactId>
- <configuration>
-
<excludedGroups>org.apache.flink.testutils.junit.FailsOnJava17</excludedGroups>
- </configuration>
- </plugin>
- </plugins>
- </pluginManagement>
+ <plugins>
Review Comment:
can we keep it in the plugin management? A profile like this shouldn't be
_enabling_ a plugin.
##########
pom.xml:
##########
@@ -1067,6 +1054,18 @@ under the License.
</plugin>
</plugins>
</pluginManagement>
+ <plugins>
+ <plugin>
+
<groupId>org.apache.maven.plugins</groupId>
+
<artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <excludedGroups>
+
${github-actions.surefire.excludedGroups},
Review Comment:
Interesting that this doesn't fail if the property is empty (i.e., theres a
leading comma).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
