mxm commented on code in PR #751: URL: https://github.com/apache/flink-kubernetes-operator/pull/751#discussion_r1450586863
########## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/resources/ResourceRequirements.java: ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.autoscaler.resources; + +/** Interface to extract resource requirements. */ +public interface ResourceRequirements { + + /** The required number of CPU for TaskManager nodes, if available, otherwise 0. */ + default double getTaskManagerCpu() { + return 0; + } + + /** The required number of CPU for TaskManager nodes, if available, otherwise 0. */ + default double getTaskManagerMemory() { Review Comment: Ok, using MemorySize. Removed interface and converted to use fields in the context. Drawback is that this affects all existing code which uses the constructor but I guess that is a fair tradeoff. ########## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/RestApiMetricsCollector.java: ########## @@ -103,6 +106,42 @@ protected Map<FlinkMetric, AggregatedMetric> queryAggregatedVertexMetrics( } } + @Override + @SneakyThrows + protected Map<FlinkMetric, Metric> queryJmMetrics(Context ctx) { + Map<String, FlinkMetric> metrics = + Map.of( + "numRegisteredTaskManagers", FlinkMetric.NUM_TASK_MANAGERS, + "taskSlotsTotal", FlinkMetric.NUM_TASK_SLOTS_TOTAL, + "taskSlotsAvailable", FlinkMetric.NUM_TASK_SLOTS_AVAILABLE); Review Comment: They still use a predicate (`equals`). I think we can refactor this independently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
