GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/2818

    [FLINK-4263] [table] SQL's VALUES does not work properly

    Thanks for contributing to Apache Flink. Before you open your pull request, 
please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your 
pull request. For more information and/or questions please refer to the [How To 
Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful 
description of your changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira 
title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the 
JIRA id)
    
    - [x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis 
build has passed
    
    This PR reworks the creation of SQL VALUES. It uses code generation and 
creates the rows within the input format, thus, we don't have to care about 
serializability of literals or rows. I updated the Janino compiler version to 
solve some compilation problems.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-4263

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2818.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2818
    
----
commit 902f32d753b0719ee0d14638ce809e81d143accf
Author: twalthr <twal...@apache.org>
Date:   2016-11-16T13:37:08Z

    [FLINK-4263] [table] SQL's VALUES does not work properly

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to