yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1452012771
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionView.java:
##########
@@ -69,10 +69,10 @@ default void notifyPriorityEvent(int priorityBufferNumber)
{}
* Get the availability and backlog of the view. The availability
represents if the view is
* ready to get buffer from it. The backlog represents the number of
available data buffers.
*
- * @param numCreditsAvailable the available credits for this {@link
ResultSubpartitionView}.
+ * @param isCreditAvailable the availability of credits for this {@link
ResultSubpartitionView}.
* @return availability and backlog.
*/
- AvailabilityWithBacklog getAvailabilityAndBacklog(int numCreditsAvailable);
+ AvailabilityWithBacklog getAvailabilityAndBacklog(boolean
isCreditAvailable);
Review Comment:
This is a must-have change, because otherwise `UnionResultSubpartitionView`
would need to determine how to distribute credits to child views, which is
unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
