Myasuka commented on code in PR #24041: URL: https://github.com/apache/flink/pull/24041#discussion_r1452465323
########## flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/taskmanager/TaskManagerProfilingFileHandler.java: ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.rest.handler.taskmanager; + +import org.apache.flink.api.common.time.Time; +import org.apache.flink.api.java.tuple.Tuple2; +import org.apache.flink.runtime.blob.TransientBlobKey; +import org.apache.flink.runtime.blob.TransientBlobService; +import org.apache.flink.runtime.clusterframework.types.ResourceID; +import org.apache.flink.runtime.resourcemanager.ResourceManagerGateway; +import org.apache.flink.runtime.rest.handler.HandlerRequest; +import org.apache.flink.runtime.rest.messages.EmptyRequestBody; +import org.apache.flink.runtime.rest.messages.ProfilingFileNamePathParameter; +import org.apache.flink.runtime.rest.messages.UntypedResponseMessageHeaders; +import org.apache.flink.runtime.rest.messages.taskmanager.TaskManagerProfilingFileMessageParameters; +import org.apache.flink.runtime.taskexecutor.FileType; +import org.apache.flink.runtime.taskexecutor.TaskExecutor; +import org.apache.flink.runtime.webmonitor.RestfulGateway; +import org.apache.flink.runtime.webmonitor.retriever.GatewayRetriever; + +import javax.annotation.Nonnull; + +import java.util.Map; +import java.util.concurrent.CompletableFuture; + +/** Rest handler which serves the profiling result file of the {@link TaskExecutor}. */ +public class TaskManagerProfilingFileHandler Review Comment: It seems you forget to change this class. ########## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerGateway.java: ########## @@ -225,16 +226,38 @@ CompletableFuture<TransientBlobKey> requestTaskManagerFileUploadByType( /** * Request the file upload from the given {@link TaskExecutor} to the cluster's {@link - * BlobServer}. The corresponding {@link TransientBlobKey} is returned. + * BlobServer}. The corresponding {@link TransientBlobKey} is returned. To support different + * type file upload with name, using {@link + * ResourceManager#requestTaskManagerFileUploadByNameAndType} as instead. * * @param taskManagerId identifying the {@link TaskExecutor} to upload the specified file * @param fileName name of the file to upload * @param timeout for the asynchronous operation * @return Future which is completed with the {@link TransientBlobKey} after uploading the file * to the {@link BlobServer}. + * @deprecated use {@link #requestTaskManagerFileUploadByNameAndType(ResourceID, String, + * FileType, Duration)} as instead. */ + @Deprecated CompletableFuture<TransientBlobKey> requestTaskManagerFileUploadByName( - ResourceID taskManagerId, String fileName, @RpcTimeout Time timeout); + ResourceID taskManagerId, String fileName, @RpcTimeout Duration timeout); Review Comment: We do not need to change the class from `Time` to `Duration` for a deprecated interface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
