curcur commented on code in PR #23514:
URL: https://github.com/apache/flink/pull/23514#discussion_r1452491216
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java:
##########
@@ -517,24 +517,27 @@ protected StreamTask(
private CheckpointStorageAccess applyFileMergingCheckpoint(
CheckpointStorageAccess checkpointStorageAccess,
FileMergingSnapshotManager fileMergingSnapshotManager) {
- if (fileMergingSnapshotManager == null) {
- return checkpointStorageAccess;
- }
-
- try {
- CheckpointStorageWorkerView mergingCheckpointStorageAccess =
- checkpointStorageAccess.toFileMergingStorage(
- fileMergingSnapshotManager, environment);
- return (CheckpointStorageAccess) mergingCheckpointStorageAccess;
- } catch (IOException e) {
- LOG.warn(
- "Initiating FsMergingCheckpointStorageAccess failed"
- + "with exception: {}, falling back to original
checkpoint storage access {}.",
- e.getMessage(),
- checkpointStorageAccess.getClass(),
- e);
- return checkpointStorageAccess;
- }
+ // TODO (FLINK-32440): enable FileMergingCheckpoint by configuration
+ return checkpointStorageAccess;
+ // if (fileMergingSnapshotManager == null) {
+ // return checkpointStorageAccess;
+ // }
+ //
+ // try {
+ // CheckpointStorageWorkerView
mergingCheckpointStorageAccess =
+ // checkpointStorageAccess.toFileMergingStorage(
+ // fileMergingSnapshotManager, environment);
+ // return (CheckpointStorageAccess)
mergingCheckpointStorageAccess;
+ // } catch (IOException e) {
+ // LOG.warn(
+ // "Initiating FsMergingCheckpointStorageAccess
failed"
+ // + "with exception: {}, falling back to
original checkpoint
+ // storage access {}.",
+ // e.getMessage(),
+ // checkpointStorageAccess.getClass(),
+ // e);
+ // return checkpointStorageAccess;
+ // }
Review Comment:
Can not leave code commented like this. Remove them if they are not needed.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/EmptySegmentFileStateHandle.java:
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.checkpoint.filemerging;
+
+import org.apache.flink.core.fs.FSDataInputStream;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.runtime.state.CheckpointedStateScope;
+
+import java.io.IOException;
+import java.io.UnsupportedEncodingException;
+
+/** An empty {@link SegmentFileStateHandle} that is only used as a
placeholder. */
+public class EmptySegmentFileStateHandle extends SegmentFileStateHandle {
Review Comment:
Is `EmptySegmentFileStateHandle` used in this PR?
If not, please remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
