[ 
https://issues.apache.org/jira/browse/FLINK-33009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806923#comment-17806923
 ] 

Chesnay Schepler commented on FLINK-33009:
------------------------------------------

I would personally be in favour of keeping this check because it is useful to 
know whether we're introducing binary incompatible changes or not. Even if we 
don't guarantee compatibility, that doesn't mean we should break things 
willy-nilly. The plugin forces us to make a conscious decision, and the cost is 
_very_ small.

> tools/release/update_japicmp_configuration.sh should only enable binary 
> compatibility checks in the release branch
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-33009
>                 URL: https://issues.apache.org/jira/browse/FLINK-33009
>             Project: Flink
>          Issue Type: Bug
>          Components: Release System
>    Affects Versions: 1.19.0
>            Reporter: Matthias Pohl
>            Assignee: Wencong Liu
>            Priority: Major
>              Labels: pull-request-available
>
> According to [Flink's API compatibility 
> constraints|https://nightlies.apache.org/flink/flink-docs-master/docs/ops/upgrading/],
>  we only support binary compatibility between patch versions. In 
> [apache-flink:pom.xml:2246|https://github.com/apache/flink/blob/aa8d93ea239f5be79066b7e5caad08d966c86ab2/pom.xml#L2246]
>  we have binary compatibility enabled even in {{master}}. This doesn't comply 
> with the rules. We should this flag disabled in {{master}}. The 
> {{tools/release/update_japicmp_configuration.sh}} should enable this flag in 
> the release branch as part of the release process.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to