xishuaidelin commented on code in PR #23827:
URL: https://github.com/apache/flink/pull/23827#discussion_r1452862528
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/aggregate/JsonObjectAggFunction.java:
##########
@@ -128,6 +137,15 @@ public void merge(Accumulator acc, Iterable<Accumulator>
others) throws Exceptio
assertKeyNotPresent(acc, key);
acc.map.put(key, other.map.get(key));
}
+ for (final StringData key : other.retractMap.keys()) {
Review Comment:
Hi xuyang, Thanks for your comments. if +U is eliminated by -U, It means two
messages has same key and value. It is an expected behaviour. However, you
reminded me that the implementation here needs to be changed. Retraction is
supposed to be done first in merge function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
