[
https://issues.apache.org/jira/browse/FLINK-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671130#comment-15671130
]
ASF GitHub Bot commented on FLINK-5082:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2820
[FLINK-5082] Pull ExecutorService lifecycle management out of the JobManager
The provided ExecutorService will no longer be closed by the JobManager.
Instead the
lifecycle is managed outside of it where it was created. This will give a
nicer behaviour,
because it better separates responsibilities.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink executorLifecycleManagement
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2820.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2820
----
commit 6bba4042b09110c8da016897b2f744e411bfb6bb
Author: Till Rohrmann <[email protected]>
Date: 2016-11-16T17:33:54Z
[FLINK-5082] Pull ExecutorService lifecycle management out of the JobManager
The provided ExecutorService will no longer be closed by the JobManager.
Instead the
lifecycle is managed outside of it where it was created. This will give a
nicer behaviour,
because it better seperates responsibilities.
----
> Pull ExecutionService lifecycle management out of the JobManager
> ----------------------------------------------------------------
>
> Key: FLINK-5082
> URL: https://issues.apache.org/jira/browse/FLINK-5082
> Project: Flink
> Issue Type: Bug
> Components: JobManager
> Affects Versions: 1.2.0, 1.1.3
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Fix For: 1.2.0, 1.1.4
>
>
> The {{JobManager}} receives an {{ExecutorService}} to run its futures as a
> constructor parameter. Even though the {{ExecutorService}} comes from
> outside, the {{JobManager}} shuts the executor service down if the
> {{JobManager}} terminates. This is clearly a sub-optimal behaviour leading
> also to {{RejectedExecutionExceptions}}.
> I propose to move the {{ExecutorService}} lifecycle management out of the
> {{JobManager}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
