XComp commented on code in PR #23970:
URL: https://github.com/apache/flink/pull/23970#discussion_r1453642234
##########
pom.xml:
##########
@@ -1110,7 +1122,11 @@ under the License.
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
-
<excludedGroups>org.apache.flink.testutils.junit.FailsOnJava17</excludedGroups>
+ <excludedGroups>
+
${github-actions.surefire.excludedGroups},
+
org.apache.flink.testutils.junit.FailsOnJava11,
+
org.apache.flink.testutils.junit.FailsOnJava17,
Review Comment:
Fair point. Right now, there's only a single test that's JDK-specific.
That's why I didn't bother that much. But I added a commit now that removes
this dependency between the different JDK version supports. I also fixed the
scenario where we want to run the AdaptiveScheduler with a JDK other than 8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
